-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport tx error messages #6982
Open
illia-malachyn
wants to merge
14
commits into
v0.33
Choose a base branch
from
illia-malachyn/6613-backport-tx-error-messages-to-v0.33
base: v0.33
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backport tx error messages #6982
illia-malachyn
wants to merge
14
commits into
v0.33
from
illia-malachyn/6613-backport-tx-error-messages-to-v0.33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transaction-result-error-messages [Access] Store Transaction Result error messages in db
…or-executionNodesForBlockID [Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct
…7-refactor-executionNodesForBlockID" This reverts commit 1a793e8.
…ll-tx-error-messages [Access] Add util command to backfill tx error messages db
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.33 #6982 +/- ##
===========================================
+ Coverage 50.97% 65.79% +14.82%
===========================================
Files 281 53 -228
Lines 23932 7099 -16833
===========================================
- Hits 12199 4671 -7528
+ Misses 10981 1934 -9047
+ Partials 752 494 -258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6468 #6525 and #6991
I didn't backport #6499 as it is unnecessary and it caused a bunch of weird errors in integration tests.